Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-client: Prepare v0.2.1 #65

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Dec 14, 2022

Follow-up patch release to #64.

//CC @thomaseizinger and @elenaf9

@thomaseizinger
Copy link
Contributor

Has someone looked into why the current release binary identifies itself as version 0.1.0?

@thomaseizinger
Copy link
Contributor

Has someone looked into why the current release binary identifies itself as version 0.1.0?

Code looks okay, perhaps the binaries attached to the release have been built before the manifest was bumped?

What do other people's dashboards say? Mine says 0.1.0.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll update the AUR package once we have release binaries.

@elenaf9
Copy link
Collaborator

elenaf9 commented Dec 15, 2022

Has someone looked into why the current release binary identifies itself as version 0.1.0?

Code looks okay, perhaps the binaries attached to the release have been built before the manifest was bumped?

What do other people's dashboards say? Mine says 0.1.0.

Which binary are you using?

@thomaseizinger
Copy link
Contributor

Has someone looked into why the current release binary identifies itself as version 0.1.0?

Code looks okay, perhaps the binaries attached to the release have been built before the manifest was bumped?

What do other people's dashboards say? Mine says 0.1.0.

Which binary are you using?

The x86 one attached to the last release.

@elenaf9 elenaf9 merged commit 6a99189 into libp2p:main Dec 16, 2022
@thomaseizinger
Copy link
Contributor

Has someone looked into why the current release binary identifies itself as version 0.1.0?

Code looks okay, perhaps the binaries attached to the release have been built before the manifest was bumped?
What do other people's dashboards say? Mine says 0.1.0.

Which binary are you using?

The x86 one attached to the last release.

Can confirm that the latest release correctly identifies itself as 0.2.1 on the dashboard. Must just be the old binary that is buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants